alterator-preinstall-0.9.2-alt1.noarch	unsafe-tmp-usage-in-scripts	fail	The test discovered scripts with errors which may be used by a user for damaging important system files. For example if a script uses in its work a temp file which is created in /tmp directory, then every user can create symlinks with the same name (pattern) in this directory in order to destroy or rewrite some system or another user's files. Scripts _must_ _use_ mktemp/tempfile or must use $TMPDIR. mktemp/tempfile is safest. $TMPDIR is safer than /tmp/ because libpam-tmpdir creates a subdirectory of /tmp that is only accessible by that user, and then sets TMPDIR and other variables to that. Hence, it doesn't matter nearly as much if you create a non-random filename, because nobody but you can access it. Found error in /usr/lib/alterator/backend3/preinstall: $ grep -A5 -B5 /tmp/ /usr/lib/alterator/backend3/preinstall # run scripts for f in "$preinstall_dir"/*; do [ -f "$f" -a -x "$f" ] || continue echo "Running $f" >>/tmp/preinstall.log if "$f" >>/tmp/preinstall.log 2>&1; then notify "package \"${f##*/}\" step $counter" counter=$(($counter + 1)) printf '%s %s - OK\n' "$(date +%T)" "$f" >&2 else notify "error \"${f##*/}\"" -- notify "package \" \" step $max" # replace itself with alteratord from chroot [ -d "$ALTERATOR_DESTDIR" ] || return 0 rm -f /tmp/alterator/.socket chroot "$ALTERATOR_DESTDIR" /etc/init.d/alteratord start mount -o bind $destdir$alteratord_socket_dir $alteratord_socket_dir # wait until new alteratord is ready to use alterator-wait;